Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add more comments #387

Merged
merged 3 commits into from
Dec 17, 2024
Merged

chore: add more comments #387

merged 3 commits into from
Dec 17, 2024

Conversation

guorong009
Copy link

Description

Add more doc comments to structs in halo2_backend

@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.87%. Comparing base (0661f46) to head (5b4026e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #387   +/-   ##
=======================================
  Coverage   83.87%   83.87%           
=======================================
  Files          76       76           
  Lines       17583    17583           
=======================================
  Hits        14747    14747           
  Misses       2836     2836           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@davidnevadoc davidnevadoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidnevadoc davidnevadoc merged commit f488a8f into main Dec 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants