Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: split create_proof #365

Merged
merged 6 commits into from
Oct 9, 2024
Merged

feat: split create_proof #365

merged 6 commits into from
Oct 9, 2024

Conversation

guorong009
Copy link

Description

  • Split the create_proof function into focused/stage functions

Related issues

Changes

  • create new focused/stage functions in Prover struct, like gen_permuted_lookups, ...
  • refactor the create_proof so that it uses the stage functions

@guorong009 guorong009 self-assigned this Sep 3, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.13%. Comparing base (553953d) to head (8e8d884).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #365      +/-   ##
==========================================
+ Coverage   85.00%   85.13%   +0.12%     
==========================================
  Files          85       85              
  Lines       18711    18862     +151     
==========================================
+ Hits        15906    16058     +152     
+ Misses       2805     2804       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guorong009 guorong009 marked this pull request as ready for review September 27, 2024 08:11
@guorong009 guorong009 requested a review from ed255 October 7, 2024 13:05
davidnevadoc
davidnevadoc approved these changes Oct 8, 2024
View reviewed changes
Copy link

@davidnevadoc davidnevadoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

halo2_backend/src/plonk/prover.rs Outdated Show resolved Hide resolved
halo2_backend/src/plonk/prover.rs Outdated Show resolved Hide resolved
guorong009 and others added 2 commits October 8, 2024 18:13
@guorong009 @davidnevadoc
chore: correct typo
308ceea 
Co-authored-by: David Nevado <[email protected]>
@guorong009 @davidnevadoc
chore: correct typo(1)
8e8d884 
Co-authored-by: David Nevado <[email protected]>
ed255
ed255 approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@ed255 ed255 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

adria0
adria0 approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@adria0 adria0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guorong009 guorong009 merged commit f0a2ebd into main Oct 9, 2024
6 checks passed
@guorong009 guorong009 deleted the gr@split-create-proof branch October 9, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ed255 ed255 ed255 approved these changes

@davidnevadoc davidnevadoc davidnevadoc approved these changes

@adria0 adria0 adria0 approved these changes

@kilic kilic Awaiting requested review from kilic

Assignees

@guorong009 guorong009

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split create_proof inner logic in focused functions/stages
5 participants
@guorong009 @codecov-commenter @adria0 @davidnevadoc @ed255