remove: Delete the gadgets folder and stop support
#241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As was proposed in #169 (comment) and we've been considering for some time already, it makes not much sense to keep maintaining the `halo2-gadgets` repo as no-one is using it and, at the same time it is time-consuming to maintain. For this reason, is getting removed.
|
Should we also remove crate::books and crate::halo2 in the same time? |
Let's remove one for PR so that we can rollback if we decide not to. Does it sound ok? I'm happy to remove them too. But let's make consistently JIC. WDYT @kilic ? |
kilic
approved these changes
Dec 19, 2023
davidnevadoc
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As was proposed in
#169 (comment) and we've been considering for some time already, it makes not much sense to keep maintaining the
halo2-gadgetsrepo as no-one is using it and, at the same time it is time-consuming to maintain.For this reason, is getting removed.