Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve root calculation for KZG setup() #211

Merged
merged 3 commits into from
Sep 21, 2023
Merged

Improve root calculation for KZG setup() #211

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8458569
improve root calculation for KZG setup()
chiro-hiro Sep 19, 2023
80b4a03
Update halo2_proofs/src/poly/kzg/commitment.rs
chiro-hiro Sep 20, 2023
b8f0901
Fix rust format issue
chiro-hiro Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 9 additions & 11 deletions halo2_proofs/src/poly/kzg/commitment.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,11 +88,12 @@ where
};

let mut g_lagrange_projective = vec![E::G1::identity(); n as usize];
let mut root = E::Scalar::ROOT_OF_UNITY_INV.invert().unwrap();
let mut root = E::Scalar::ROOT_OF_UNITY;
for _ in k..E::Scalar::S {
root = root.square();
}
let n_inv = Option::<E::Scalar>::from(E::Scalar::from(n).invert())
let n_inv = E::Scalar::from(n)
.invert()
.expect("inversion should be ok for n = 1<<k");
let multiplier = (s.pow_vartime([n]) - E::Scalar::ONE) * n_inv;
parallelize(&mut g_lagrange_projective, |g, start| {
Expand All @@ -106,11 +107,9 @@ where

let g_lagrange = {
let mut g_lagrange = vec![E::G1Affine::identity(); n as usize];
parallelize(&mut g_lagrange, |g_lagrange, starts| {
E::G1::batch_normalize(
&g_lagrange_projective[starts..(starts + g_lagrange.len())],
g_lagrange,
);
parallelize(&mut g_lagrange, |g_lagrange, start| {
let end = start + g_lagrange.len();
E::G1::batch_normalize(&g_lagrange_projective[start..end], g_lagrange);
});
drop(g_lagrange_projective);
g_lagrange
Expand Down Expand Up @@ -142,10 +141,9 @@ where
Self {
k,
n: 1 << k,
g_lagrange: if let Some(g_l) = g_lagrange {
g_l
} else {
g_to_lagrange(g.iter().map(PrimeCurveAffine::to_curve).collect(), k)
g_lagrange: match g_lagrange {
Some(g_l) => g_l,
None => g_to_lagrange(g.iter().map(PrimeCurveAffine::to_curve).collect(), k),
},
g,
g2,
Expand Down
Loading