WIP: ProverV2 implementation #249
Annotations
4 errors and 12 warnings
missing documentation for an associated function:
halo2_proofs/src/plonk/prover.rs#L60
error: missing documentation for an associated function
--> halo2_proofs/src/plonk/prover.rs:60:5
|
60 | / pub fn new(
61 | | params: &'params Scheme::ParamsProver,
62 | | pk: &ProvingKeyV2<Scheme::Curve>,
63 | | circuit: &CompiledCircuitV2<Scheme::Scalar>,
... |
68 | | where
69 | | Scheme::Scalar: WithSmallOrderMulGroup<3> + FromUniformBytes<64>,
| |_________________________________________________________________________^
|
type does not implement `std::fmt::Debug`; consider adding `#[derive(Debug)]` or a manual implementation:
halo2_proofs/src/plonk/prover.rs#L38
error: type does not implement `std::fmt::Debug`; consider adding `#[derive(Debug)]` or a manual implementation
--> halo2_proofs/src/plonk/prover.rs:38:1
|
38 | / pub struct ProverV2<
39 | | 'params,
40 | | Scheme: CommitmentScheme,
41 | | P: Prover<'params, Scheme>,
... |
48 | | _marker: std::marker::PhantomData<(Scheme, P, E, R, T)>,
49 | | }
| |_^
|
note: the lint level is defined here
--> halo2_proofs/src/lib.rs:7:9
|
7 | #![deny(missing_debug_implementations)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
missing documentation for a struct:
halo2_proofs/src/plonk/prover.rs#L38
error: missing documentation for a struct
--> halo2_proofs/src/plonk/prover.rs:38:1
|
38 | / pub struct ProverV2<
39 | | 'params,
40 | | Scheme: CommitmentScheme,
41 | | P: Prover<'params, Scheme>,
... |
44 | | T: TranscriptWrite<Scheme::Curve, E>,
45 | | > {
| |_^
|
note: the lint level is defined here
--> halo2_proofs/src/lib.rs:8:9
|
8 | #![deny(missing_docs)]
| ^^^^^^^^^^^^
|
Clippy (beta)
Clippy had exited with the 101 exit code
|
fields `params` and `instance` are never read:
halo2_proofs/src/plonk/prover.rs#L46
warning: fields `params` and `instance` are never read
--> halo2_proofs/src/plonk/prover.rs:46:5
|
38 | pub struct ProverV2<
| -------- fields in this struct
...
46 | params: &'params Scheme::ParamsProver,
| ^^^^^^
47 | instance: Vec<InstanceSingle<Scheme::Curve>>,
| ^^^^^^^^
|
fields `instance_values` and `instance_polys` are never read:
halo2_proofs/src/plonk/prover.rs#L34
warning: fields `instance_values` and `instance_polys` are never read
--> halo2_proofs/src/plonk/prover.rs:34:9
|
33 | struct InstanceSingle<C: CurveAffine> {
| -------------- fields in this struct
34 | pub instance_values: Vec<Polynomial<C::Scalar, LagrangeCoeff>>,
| ^^^^^^^^^^^^^^^
35 | pub instance_polys: Vec<Polynomial<C::Scalar, Coeff>>,
| ^^^^^^^^^^^^^^
|
multiple fields are never read:
halo2_proofs/src/plonk/circuit.rs#L1569
warning: multiple fields are never read
--> halo2_proofs/src/plonk/circuit.rs:1569:16
|
1568 | pub struct ConstraintSystemV2Backend<F: Field> {
| ------------------------- fields in this struct
1569 | pub(crate) num_fixed_columns: usize,
| ^^^^^^^^^^^^^^^^^
1570 | pub(crate) num_advice_columns: usize,
| ^^^^^^^^^^^^^^^^^^
...
1573 | pub(crate) num_challenges: usize,
| ^^^^^^^^^^^^^^
...
1576 | pub(crate) unblinded_advice_columns: Vec<usize>,
| ^^^^^^^^^^^^^^^^^^^^^^^^
...
1579 | pub(crate) advice_column_phase: Vec<sealed::Phase>,
| ^^^^^^^^^^^^^^^^^^^
1580 | /// Contains the phase for each challenge. Should have same length as num_challenges.
1581 | pub(crate) challenge_phase: Vec<sealed::Phase>,
| ^^^^^^^^^^^^^^^
...
1608 | pub(crate) general_column_annotations: HashMap<metadata::Column, String>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `ConstraintSystemV2Backend` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
|
multiple fields are never read:
halo2_proofs/src/plonk.rs#L392
warning: multiple fields are never read
--> halo2_proofs/src/plonk.rs:392:5
|
390 | pub struct ProvingKeyV2<C: CurveAffine> {
| ------------ fields in this struct
391 | vk: VerifyingKeyV2<C>,
392 | l0: Polynomial<C::Scalar, ExtendedLagrangeCoeff>,
| ^^
393 | l_last: Polynomial<C::Scalar, ExtendedLagrangeCoeff>,
| ^^^^^^
394 | l_active_row: Polynomial<C::Scalar, ExtendedLagrangeCoeff>,
| ^^^^^^^^^^^^
395 | fixed_values: Vec<Polynomial<C::Scalar, LagrangeCoeff>>,
| ^^^^^^^^^^^^
396 | fixed_polys: Vec<Polynomial<C::Scalar, Coeff>>,
| ^^^^^^^^^^^
397 | fixed_cosets: Vec<Polynomial<C::Scalar, ExtendedLagrangeCoeff>>,
| ^^^^^^^^^^^^
398 | permutation: permutation::ProvingKey<C>,
| ^^^^^^^^^^^
399 | ev: Evaluator<C>,
| ^^
|
= note: `ProvingKeyV2` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis
|
fields `fixed_commitments`, `permutation` and `cs_degree` are never read:
halo2_proofs/src/plonk.rs#L51
warning: fields `fixed_commitments`, `permutation` and `cs_degree` are never read
--> halo2_proofs/src/plonk.rs:51:5
|
49 | pub struct VerifyingKeyV2<C: CurveAffine> {
| -------------- fields in this struct
50 | domain: EvaluationDomain<C::Scalar>,
51 | fixed_commitments: Vec<C>,
| ^^^^^^^^^^^^^^^^^
52 | permutation: permutation::VerifyingKey<C>,
| ^^^^^^^^^^^
...
55 | cs_degree: usize,
| ^^^^^^^^^
|
= note: `VerifyingKeyV2` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis
= note: `#[warn(dead_code)]` on by default
|
variable does not need to be mutable:
halo2_proofs/src/plonk/prover.rs#L65
warning: variable does not need to be mutable
--> halo2_proofs/src/plonk/prover.rs:65:9
|
65 | mut rng: R,
| ----^^^
| |
| help: remove this `mut`
|
= note: `#[warn(unused_mut)]` on by default
|
unused variable: `rng`:
halo2_proofs/src/plonk/prover.rs#L65
warning: unused variable: `rng`
--> halo2_proofs/src/plonk/prover.rs:65:13
|
65 | mut rng: R,
| ^^^ help: if this is intentional, prefix it with an underscore: `_rng`
|
= note: `#[warn(unused_variables)]` on by default
|
Clippy (beta)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|