Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use https for backend and add test cert #15

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Conversation

ctrlc03
Copy link
Collaborator

@ctrlc03 ctrlc03 commented Aug 28, 2024

No description provided.

@ctrlc03 ctrlc03 requested a review from JohnGuilding August 28, 2024 13:18
Copy link
Collaborator

@JohnGuilding JohnGuilding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on updating the frontend so that it works with these changes as part of this PR?

@ctrlc03
Copy link
Collaborator Author

ctrlc03 commented Aug 28, 2024

Thoughts on updating the frontend so that it works with these changes as part of this PR?

good point, will do that

@ctrlc03
Copy link
Collaborator Author

ctrlc03 commented Aug 28, 2024

Thoughts on updating the frontend so that it works with these changes as part of this PR?

good point, will do that

@JohnGuilding updated frontend to accept url from .env - first time use you'll need to navigate to https://localhost:3001 and approve self signed cert before the frontend can use it (will need proper cert for backend to use https in prod)

@ctrlc03 ctrlc03 force-pushed the feat/use-https branch 2 times, most recently from 466ee5e to f218e57 Compare August 29, 2024 14:26
Copy link

vercel bot commented Aug 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hacking-pse ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2024 2:39pm

Copy link
Collaborator

@JohnGuilding JohnGuilding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lfg

@JohnGuilding JohnGuilding merged commit 6b16074 into main Aug 29, 2024
3 checks passed
@JohnGuilding JohnGuilding deleted the feat/use-https branch August 29, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants