Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more intuitive explanation and blackbox #23

Merged
merged 14 commits into from
May 31, 2024
Merged

Add more intuitive explanation and blackbox #23

merged 14 commits into from
May 31, 2024

Conversation

NOOMA-42
Copy link
Collaborator

@NOOMA-42 NOOMA-42 commented Feb 7, 2024 •
edited
Loading

Description

Add more intuitive explanation and blackbox

Related Issues

#24

Affected Tutorials

  • Module Name: 1, 2, 3, 4

Type of Change

  • Typo/grammar fix
  • Code correction (e.g., a bug in a code snippet)
  • New tutorial or section
  • Other (please describe):

Testing

NA

Checklist

  • I have performed a self-review of my own changes.
  • I have made corresponding changes to related documentation.

@NOOMA-42 NOOMA-42 marked this pull request as ready for review February 8, 2024 06:53
adrianmcli
adrianmcli requested changes May 31, 2024
View reviewed changes
Copy link
Collaborator

@adrianmcli adrianmcli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I applied some changes directly in my own commit but I found it easier to just use the suggest changes feature. So maybe just accept the changes and let's merge.

MODULE_3.md Outdated Show resolved Hide resolved
MODULE_3.md Outdated Show resolved Hide resolved
MODULE_3.md Outdated Show resolved Hide resolved
MODULE_3.md Outdated Show resolved Hide resolved
MODULE_3.md Outdated Show resolved Hide resolved
MODULE_3.md Outdated Show resolved Hide resolved
MODULE_4.md Outdated Show resolved Hide resolved
@NOOMA-42
Copy link
Collaborator Author

I've updated with all your suggestions and add hackathon week plan

@adrianmcli adrianmcli merged commit 2ad74e3 into privacy-scaling-explorations:main May 31, 2024
@NOOMA-42 NOOMA-42 deleted the feat--blackbox branch May 31, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianmcli adrianmcli adrianmcli requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NOOMA-42 @adrianmcli