This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
Develop keccak #89
Merged
Develop keccak #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into develop-poseidon
1. Bug fixed 2. Code optimization 3. Remove useless annotations
1. reduce advice_column count 2. reduce constraint count 3. reduce step count
leolara
force-pushed
the
main
branch
4 times, most recently
from
03ddbb5 to
8397503
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
=======================================
Coverage 62.34% 62.35%
=======================================
Files 26 26
Lines 8284 8285 +1
=======================================
+ Hits 5165 5166 +1
Misses 3119 3119 ☔ View full report in Codecov by Sentry. |
1. Reduce constraints degree 2. Add constraint for checking padding rule 3. Bugfix 4. Remove redundant code
leolara
reviewed
Mar 27, 2024
Cargo.toml
Outdated
| @@ -20,6 +20,7 @@ num-bigint = { version = "0.4", features = ["rand"] } | |||
| uuid = { version = "1.4.0", features = ["v1", "rng"] } | |||
| serde = { version = "1.0", features = ["derive"] } | |||
| serde_json = "1.0" | |||
| ff = "0.13.0" | |||
There was a problem hiding this comment.
@10to4 why is this package required, it seems it is not used
There was a problem hiding this comment.
Yes, I think this should be legacy useless code.
leolara
approved these changes
Mar 27, 2024
|
@10to4 I have approved it, perhaps you can fix those clippy errors and merge it :-) |
…to develop-keccak
Merged
via the queue into
privacy-scaling-explorations:main
with commit Mar 27, 2024
1788d7e
4 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.