This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
Parse HyperTransition syntax #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxkzmn
commented
Aug 26, 2024
| @@ -37,9 +37,9 @@ pub Statements: Vec<Statement<BigInt, Identifier>> = { | |||
| } | |||
|
|
|||
| ParseStatement: Statement<BigInt, Identifier> = { | |||
| <l: @L> <s: StatementType> ";" <r: @R> => add_dsym(dsym_factory.create(l,r), s), | |||
There was a problem hiding this comment.
Each statement type already has its own L and R parsing, so add_dsym wasn't needed anymore.
leolara
reviewed
Aug 27, 2024
src/parser/chiquito.lalrpop
Outdated
| } | ||
|
|
||
| Call: Statement<BigInt, Identifier> = { | ||
| <l: @L> <ids: ParseIdsList> "<==" <machine: Identifier> "(" <es:ParseExpressionList> ")" <r: @R> => Statement::Call(dsym_factory.create(l,r), ids, machine, es), |
There was a problem hiding this comment.
As a call can be part of an expression in general, probably in the future when we implement actual function calls, it should be an Expression and not an statement @alxkzmn
There was a problem hiding this comment.
Got it, will implement.
leolara
approved these changes
Aug 28, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.