This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
Expose debug symbol start and end for the language server #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leolara
suggested changes
Aug 23, 2024
src/parser/ast/mod.rs
Outdated
| @@ -141,6 +141,22 @@ impl PartialEq for DebugSymRef { | |||
| } | |||
| } | |||
|
|
|||
| /// Interface of the debug symbol reference to use with the Chiquito language server | |||
| pub trait LanguageServerInterface { | |||
There was a problem hiding this comment.
@alxkzmn I don't think it is custom in Rust to call Interface to a trait. Also, the interface is used by the Language Server, not an interface to the Language Server.
There was a problem hiding this comment.
Could be something like GetPos? or something refering to the actions that are allowed by the trait
leolara
approved these changes
Aug 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have accidentally made the start and end of debug symbol private, so here's a fix for the language server. Also had to update the halo2 to the latest version because the language server didn't want to compile (there was a missing bound on a variable generic inside the halo2 middleware
Expression, not sure why Chiquito itself compiled successfully).