-
Notifications
You must be signed in to change notification settings - Fork 39
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this PR allows the auto_eq
feature which automatically assigns the left hand side queriable of a regular constraint. I'm good with the implementation of this feature and left a couple comments on some potential improvements. Let me know if you agree! @leolara
Looking forward, there are more things we can do:
- Allow auto witness generation for constraints other than
eq
. - Allow auto witness generation for transition constraints and signals with rotation as well.
- Similar to PIL, we could eventually enable an auto witness generation "mode" where instead of using the
auto_eq
API, the user only needs to provide the initial trace input and all signals in all step instances will be inferred, or return an error saying that not enough trace input was provided.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with additional features to be implemented in future PRs.
@leolara Good to go after fixing the conflicts. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #152 +/- ##
==========================================
+ Coverage 48.02% 49.81% +1.79%
==========================================
Files 21 21
Lines 5483 5729 +246
==========================================
+ Hits 2633 2854 +221
- Misses 2850 2875 +25
☔ View full report in Codecov by Sentry. |
This is useful for: