Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

Small corrections in the tutorials #145

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

sraver
Copy link
Contributor

@sraver sraver commented Oct 3, 2023

Changes have been made in three different chapters:

  • Part 1: Include installation of jupyterlab package to allow running the Lab
  • Part 2/Chapter 3: Remove outdated comment about the parameters of wg having to be a single variable
  • Part 2/Chapter 4: Update the variable and step type to match the newly created type of step

@leolara leolara requested a review from qwang98 October 14, 2023 06:55
@leolara
Copy link
Collaborator

leolara commented Oct 14, 2023

@qwang98 please review and approve this

@qwang98
Copy link
Collaborator

qwang98 commented Oct 27, 2023

These are all good fixes but tutorials are now all moved under the book folder and this can't be merged. @sraver Would you mind moving these fixes to (either in this PR or a new one):

https://github.com/privacy-scaling-explorations/chiquito/blob/main/book/part1_chapter5.ipynb?short_path=9eb3361#L87-L90
https://github.com/privacy-scaling-explorations/chiquito/blob/main/book/part2_chapter2.ipynb
https://github.com/privacy-scaling-explorations/chiquito/blob/main/book/part2_chapter4.ipynb

I could have also done it, but don't want to have my name appear under the commit. Thanks!

@sraver sraver force-pushed the fix/tutorials branch 2 times, most recently from 8836988 to 7712805 Compare October 30, 2023 08:30
@sraver
Copy link
Contributor Author

sraver commented Oct 30, 2023

@qwang98 updated!

@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (009690b) 46.84% compared to head (d9365f9) 46.84%.
Report is 2 commits behind head on main.

❗ Current head d9365f9 differs from pull request most recent head f8a34bc. Consider uploading reports for the commit f8a34bc to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #145   +/-   ##
=======================================
  Coverage   46.84%   46.84%           
=======================================
  Files          21       21           
  Lines        5364     5364           
=======================================
  Hits         2513     2513           
  Misses       2851     2851           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qwang98
Copy link
Collaborator

qwang98 commented Oct 30, 2023

LGTM thanks!

@qwang98 qwang98 added this pull request to the merge queue Oct 30, 2023
Merged via the queue into privacy-scaling-explorations:main with commit 4bdf8eb Oct 30, 2023
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants