This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 39
Automatic plaf instance - Issue #129 #133
Closed
jae-cuz
wants to merge
11
commits into
privacy-scaling-explorations:main
from
jae-cuz:automatic-plaf-instance
Closed
Automatic plaf instance - Issue #129 #133
jae-cuz
wants to merge
11
commits into
privacy-scaling-explorations:main
from
jae-cuz:automatic-plaf-instance
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tried generalizaiton with reference to https://github.com/Dhole/polyexen/blob/master/src/plaf/backends/halo2.rs#L346-L367 |
So, actually this is better if we do in plaf codebase, because it is in their responsability boundary,. So I would send this as a PR there. But keep this open in case they don't accept it we can add it here. |
Please, paste here the link to the PR to plaf when you have sent it, so we can track if it gets merged. |
Here is my PR to plaf : Dhole/polyexen#3 I would make a new issue if it is merged :) Thanks |
Move to #144. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #129. Implemented automatic plaf instance generation.
use chiquito::plonkish::backend::plaf::PlafInstance
would enableplaf_circuit.instance()
.Ready for review @leolara @qwang98
instance_with_offsets
: vector of pair(witness value, public offset)
, where public offset indicates the order to be returnedinstance_with_offsets
with public offsetinstance_values
: convert witness values ininstance_with_offsets
to fieldSee along with example :