This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
Generalize fibonacci rust example - Issue #128 #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leolara
reviewed
Sep 15, 2023
examples/fibo_with_padding.rs
Outdated
| // Fibonacci sequence is 10. (one less than num_steps above) | ||
|
|
||
| // Expose the result of calculation and round number | ||
| ctx.expose(b, chiquito::ast::ExposeOffset::Last); |
There was a problem hiding this comment.
@jae-cuz do a use chiquito::ast::ExposeOffset
|
@qwang98 you are the reviewer of this |
I agree that we should remove repetitive comments from |
qwang98
approved these changes
Sep 17, 2023
|
I'm good with this! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #128.
@leolara @qwang98 Ready for review. Added comments for added functionalities.
One thing to ask:
If we add a new file
fibo_with_padding.rs, should we erase the same comments fromfibonacci.rs? Please advise. Thanks!