Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

add unit test code for FixedGenContext - Issue #104 #127

Merged
merged 4 commits into from
Sep 14, 2023

Conversation

saeyoon17
Copy link
Contributor

Hi, I wrote two unit tests regarding FixedGenContext as suggested in Issue #104.

  • test_fixed_gen_context() checks the length of assignment is 1 given a single fixed column.
  • test_fixed_gen_context_multiple() checks the length of assignment is 2 given two column assignments.

Please let me know if anything else is required. :)

@leolara
Copy link
Collaborator

leolara commented Sep 13, 2023

@saeyoon17 I think we should test that the values are correct, not just the length

@leolara leolara self-requested a review September 13, 2023 07:47
@saeyoon17
Copy link
Contributor Author

@leolara I changed the test so that it now checks the value. Please tell me if there are any other modifications we should make. :)

@leolara
Copy link
Collaborator

leolara commented Sep 13, 2023

@saeyoon17 it is approved, does it show the button to merge to you?

@saeyoon17
Copy link
Contributor Author

@leolara No.. I think I only have the read access to this repository. This is how I see it:

image

@qwang98
Copy link
Collaborator

qwang98 commented Sep 14, 2023

@leolara I think only maintainers are allowed to merge it. Any means we can change this in the repo settings?

@leolara leolara added this pull request to the merge queue Sep 14, 2023
Merged via the queue into privacy-scaling-explorations:main with commit d14d9a0 Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants