-
Notifications
You must be signed in to change notification settings - Fork 39
Move use chiquito::dsl::cb::* to circuit lambda #124
Move use chiquito::dsl::cb::* to circuit lambda #124
Conversation
And I suppose you meant result_plaf in println? chiquito/examples/fibonacci.rs Lines 152 to 154 in c4891ae
Please let me know if you want separate issue for this or not. Thanks :) |
Yes. Thanks for catching. Please fix. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to merge after fixing the result_plaf.
@jae-cuz Feel free to merge once the work flow run clears! |
@qwang98 Should I fmt or leave it? Also, could you explain what we can do for all the release fails (including other prs) ? Thanks. |
@jae-cuz you should fix the build before merging. You can click on details on the failed checks see what are the errors and fix them. One thing that can help is to run |
There was previously one build error that was not related to this and fixed in main. However, the Rustfmt error stays, and should be fixed in this PR before merging |
@leolara Thanks for your kind explanation! |
@leolara Is there also a way to allow non-maintainers to run CI jobs in the settings? |
I merged this for now but I think we should enable non maintainers to merge in the future. |
Hi maintainers, I'm student from PSE Summer Contribution program.
I just followed the mentioned part in #22 .
Comments would help me a lot :) Thanks!