Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

Move use chiquito::dsl::cb::* to circuit lambda #124

Merged

Conversation

jae-cuz
Copy link
Contributor

@jae-cuz jae-cuz commented Sep 10, 2023

Hi maintainers, I'm student from PSE Summer Contribution program.

I just followed the mentioned part in #22 .

Comments would help me a lot :) Thanks!

@jae-cuz
Copy link
Contributor Author

jae-cuz commented Sep 10, 2023

And I suppose you meant result_plaf in println?

let result_plaf = prover_plaf.verify_par();
println!("result = {:#?}", result);

Please let me know if you want separate issue for this or not. Thanks :)

@qwang98
Copy link
Collaborator

qwang98 commented Sep 11, 2023

And I suppose you meant result_plaf in println?

let result_plaf = prover_plaf.verify_par();
println!("result = {:#?}", result);

Please let me know if you want separate issue for this or not. Thanks :)

Yes. Thanks for catching. Please fix. Thanks!

@qwang98 qwang98 self-requested a review September 11, 2023 01:41
Copy link
Collaborator

@qwang98 qwang98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge after fixing the result_plaf.

@qwang98
Copy link
Collaborator

qwang98 commented Sep 11, 2023

@jae-cuz Feel free to merge once the work flow run clears!

@jae-cuz
Copy link
Contributor Author

jae-cuz commented Sep 11, 2023

@qwang98 Should I fmt or leave it?

Also, could you explain what we can do for all the release fails (including other prs) ? Thanks.

@leolara
Copy link
Collaborator

leolara commented Sep 13, 2023

@jae-cuz you should fix the build before merging. You can click on details on the failed checks see what are the errors and fix them.

One thing that can help is to run make precommit

@leolara
Copy link
Collaborator

leolara commented Sep 13, 2023

There was previously one build error that was not related to this and fixed in main. However, the Rustfmt error stays, and should be fixed in this PR before merging

@jae-cuz
Copy link
Contributor Author

jae-cuz commented Sep 13, 2023

@leolara Thanks for your kind explanation!

@qwang98
Copy link
Collaborator

qwang98 commented Sep 14, 2023

@leolara Is there also a way to allow non-maintainers to run CI jobs in the settings?

@qwang98 qwang98 added this pull request to the merge queue Sep 14, 2023
Merged via the queue into privacy-scaling-explorations:main with commit 4b20bf3 Sep 14, 2023
@qwang98
Copy link
Collaborator

qwang98 commented Sep 14, 2023

I merged this for now but I think we should enable non maintainers to merge in the future.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants