Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure counter content is exposed to screen reader users #3270

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Ensure counter content is exposed to screen reader users #3270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b73329d
Fix aria-hidden bug
khiga8 Jan 15, 2025
5f8c56d
Remove button test
khiga8 Jan 16, 2025
654b1ae
Create poor-parrots-fold.md
khiga8 Jan 17, 2025
49caf4b
Generating component snapshots
khiga8 Jan 17, 2025
73d3089
Merge branch 'main' into kh-fix-10088
khiga8 Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/poor-parrots-fold.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@fake-scope/fake-pkg": patch
---

Ensure counter content is exposed to screen reader users
6 changes: 3 additions & 3 deletions ...ts/snapshots.test.ts-snapshots/primer/beta/button/invisible_all_visuals/aria-snapshot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
- button "Button"
- button "Button"
- button "Button"
- button "Button ( )": Button ()
- button "Button ( )": Button ()
- button "Button ( )": Button ()
- button "Button ( 15 )"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

- button "Button ( 15 )"
- button "Button ( 15 )"
- button "Button with tooltip"
2 changes: 1 addition & 1 deletion ...enshots/snapshots.test.ts-snapshots/primer/beta/button/trailing_counter/aria-snapshot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
- button "Star ( )": Star ()
- button "Star ( 15 )"
2 changes: 1 addition & 1 deletion ...eenshots/snapshots.test.ts-snapshots/primer/beta/button/trailing_visual/aria-snapshot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
- button "Comment ( )": Comment ()
- button "Comment ( 15 )"
2 changes: 1 addition & 1 deletion app/components/primer/beta/button.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
<% if trailing_visual %>
<span class="Button-visual Button-trailingVisual">
<% if @trailing_visual_counter %>
<span class="d-flex" aria-hidden="true"><%= trailing_visual %></span>
Copy link
Contributor Author

@khiga8 khiga8 Jan 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting flex on this newly added span to ensure content remains centered.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No visual regression - good sign!

<span class="sr-only">(<%= trailing_visual %>)</span>
<%= trailing_visual %>
<% else %>
<%= trailing_visual %>
<% end %>
Expand Down
2 changes: 1 addition & 1 deletion app/components/primer/beta/button.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ class Button < Primer::Component
label: Primer::Beta::Label,
counter: lambda { |**system_arguments|
@trailing_visual_counter = true
Primer::Beta::Counter.new("aria-hidden": true, **system_arguments)
Primer::Beta::Counter.new(**system_arguments)
}
}

Expand Down
Loading