add more backdrop selectors to properly inherit theme colors (#2549)

* add more backdrop selectors to properly inherit theme colors * changeset
primer · Nov 17, 2023 · df764e1 · df764e1
1 parent 4518cc4
commit df764e1
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 1 deletion.
diff --git a/.changeset/popular-hounds-sin.md b/.changeset/popular-hounds-sin.md
@@ -0,0 +1,5 @@
+---
+'@primer/css': patch
+---
+
+Fix styles for ::backdrop
diff --git a/src/support/mixins/color-modes.scss b/src/support/mixins/color-modes.scss
@@ -31,7 +31,7 @@
     }
 
     ::backdrop,
-    [data-color-mode="light"][data-light-theme="#{$theme-name}"],
+    [data-color-mode="light"][data-light-theme="#{$theme-name}"]::backdrop,
     [data-color-mode="dark"][data-dark-theme="#{$theme-name}"]::backdrop {
       @content;
 
@@ -47,6 +47,14 @@
         @content;
       }
     }
+
+    ::backdrop,
+    [data-color-mode="light"][data-light-theme="#{$theme-name}"]::backdrop,
+    [data-color-mode="dark"][data-dark-theme="#{$theme-name}"]::backdrop {
+      @content;
+
+      /*! */ // Must remain separate from the above selector to not break browsers which don't support ::backdrop, e.g. Safari 14.
+    }
   }
 
   @media (prefers-color-scheme: light) {
@@ -56,6 +64,12 @@
         @content;
       }
     }
+
+    [data-color-mode="auto"][data-light-theme="#{$theme-name}"]::backdrop {
+      @content;
+
+      /*! */ // Must remain separate from the above selector to not break browsers which don't support ::backdrop, e.g. Safari 14.
+    }
   }
 
   @media (prefers-color-scheme: dark) {
@@ -65,6 +79,12 @@
         @content;
       }
     }
+
+    [data-color-mode="auto"][data-light-theme="#{$theme-name}"]::backdrop {
+      @content;
+
+      /*! */ // Must remain separate from the above selector to not break browsers which don't support ::backdrop, e.g. Safari 14.
+    }
   }
 }