Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Hero heading and description #684

Merged
merged 8 commits into from
Aug 8, 2024

Conversation

danielguillan
Copy link
Contributor

@danielguillan danielguillan commented Aug 7, 2024

Summary

Extends the Hero component's heading and description to improve readability and balance. Solves #618

List of notable changes:

  • Heading has now a max-width of 924px (equivalent to 9 grid columns)
  • Description has now a max-width of 600px (equivalent of 6 grid columns)
  • Added text-wrap: balance to the heading as a progressive enhancement to prevent orphans and create more balanced text lines.

What should reviewers focus on?

Contributor checklist:

  • All new and existing CI checks pass
  • Tests prove that the feature works and covers both happy and unhappy paths
  • Any drop in coverage, breaking changes or regressions have been documented above
  • New visual snapshots have been generated / updated for any UI changes
  • All developer debugging and non-functional logging has been removed
  • Related issues have been referenced in the PR description

Reviewer checklist:

  • Check that pull request and proposed changes adhere to our contribution guidelines and code of conduct
  • Check that tests prove the feature works and covers both happy and unhappy paths
  • Check that there aren't other open Pull Requests for the same update/change

Screenshots:

Please try to provide before and after screenshots or videos

Before After
image

Copy link

changeset-bot bot commented Aug 7, 2024

🦋 Changeset detected

Latest commit: 0b2e5ff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@primer/react-brand Minor
@primer/brand-primitives Minor
@primer/brand-e2e Minor
@primer/brand-fonts Minor
@primer/brand-config Minor
@primer/brand-storybook Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 7, 2024

🟢 No design token changes found

Copy link
Contributor

github-actions bot commented Aug 7, 2024

⚠️ Visual differences found

Our visual comparison tests found UI differences.

Please review the differences by using the test artifacts to ensure that the changes were intentional.

Artifacts can be downloaded and reviewed locally.

Download links are available at the bottom of the workflow summary screen.

Example:

artifacts section of workflow run

If the changes are expected, please run npm run test:visual:update-snapshots to replace the previous fixtures.

Review visual differences

@danielguillan danielguillan merged commit e382a49 into main Aug 8, 2024
@danielguillan danielguillan deleted the danielguillan/extend-hero-heading branch August 8, 2024 14:43
@primer-css primer-css mentioned this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants