Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call onCellEditComplete callback on cell edit completion in tree table, document issue w… #7636

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MBelniak
Copy link
Contributor

@MBelniak MBelniak commented Jan 22, 2025

…ith updating cells

Defect Fixes

Fix #7635

Feature Requests

Due to company policy, we are unable to accept feature request PRs with significant changes as such cases has to be implemented by our team following our own processes.
Smaller scaled feature implementations such as adding a property to a component will be considered for merging.

Copy link

vercel bot commented Jan 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2025 4:20pm
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2025 4:20pm

Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@MBelniak MBelniak changed the title Call callback on cell edit completion in tree table, document issue w… Call onCellEditComplete callback on cell edit completion in tree table, document issue w… Jan 22, 2025
Copy link
Member

@melloware melloware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to me. But I would want @mertsincan to review this

@melloware melloware added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TreeTable: onCellEditComplete not called
3 participants