Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix decade title logic, fixes #17326 #17327

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rosenthalj
Copy link
Contributor

@rosenthalj rosenthalj commented Jan 8, 2025

fix #17326

changed *ngIf="!decadeTemplate && _decadeTemplate" to *ngIf="!decadeTemplate && !_decadeTemplate">

This video shows the v19 PrimeNG DatePicker Basic dem's Decade title working correctly after the fix.

v19DatePickerYearViewFix.mov

changed *ngIf="!decadeTemplate && _decadeTemplate" to *ngIf="!decadeTemplate && !_decadeTemplate">
Copy link

vercel bot commented Jan 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Jan 8, 2025 10:10am
primeng-v18 ⬜️ Ignored (Inspect) Visit Preview Jan 8, 2025 10:10am

Copy link

vercel bot commented Jan 8, 2025

@rosenthalj is attempting to deploy a commit to the primetek Team on Vercel.

A member of the Team first needs to authorize it.

@SoyDiego
Copy link
Contributor

SoyDiego commented Jan 8, 2025

Correct the description of your PR to "fix #17326" and this PR will be linked with the issue and when they approve it, will close automatically :)

@rosenthalj rosenthalj changed the title fix: fixed #17326 decade title logic fix #17326: decade title logic Jan 8, 2025
@rosenthalj rosenthalj changed the title fix #17326: decade title logic fix decade title logic, fixes #17326 Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DatePicker fails to show "decade" title
2 participants