Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored tooltips position and alignment method #17067

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

rajkeshwar
Copy link
Contributor

What's changed

  • Refactored the align method to enhance readability and optimize the code structure.
  • Consolidated common logic within the alignTop, alignBottom, alignRight, and alignLeft methods for improved maintainability and consistency.

Copy link

vercel bot commented Dec 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Dec 16, 2024 0:15am

Copy link

vercel bot commented Dec 16, 2024

@rajkeshwar is attempting to deploy a commit to the primetek Team on Vercel.

A member of the Team first needs to authorize it.

@mertsincan mertsincan added Resolution: Needs Issue An issue needs to be created for the pull request Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. and removed Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. labels Dec 16, 2024
@mertsincan
Copy link
Member

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue

@rajkeshwar
Copy link
Contributor Author

Hi @mertsincan,

Thank you for the information. Based on the GitHub documentation for manually linking a pull request to an issue, it seems that anyone with write permissions for a repository can link an issue.

To assist with this, I’ve created an issue: #17084. Could you kindly link it?

@mertsincan mertsincan removed the Resolution: Needs Issue An issue needs to be created for the pull request label Dec 17, 2024
@mertsincan mertsincan linked an issue Dec 17, 2024 that may be closed by this pull request
@mertsincan mertsincan merged commit 2aff865 into primefaces:master Dec 17, 2024
1 of 2 checks passed
@mertsincan
Copy link
Member

Thanks a lot for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve tooltips position and alignment method
2 participants