fix: escape closes only necessary elements #17052
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LoaderB0T is attempting to deploy a commit to the primetek Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16955
This is a PR to fix the mentioned issue.
It reliably fixes the problems with panels other than dialogs. When multiple dialogs are opened, they still all close with escape if there is no active focus within one of the dialogs. If the activeElement is within one of the dialogs, only that dialog will be closed.
Open for ideas on how to solve the closing of all dialogs when no dialog is focussed, however not required to fix the issue at hand (panels closing also closing the dialog itself).
Hoping for reviews & merge :)