Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#16630): ensure aria-describedby is dynamically set and removed for tooltip #16889

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

dermartinschmitz
Copy link
Contributor

@dermartinschmitz dermartinschmitz commented Nov 29, 2024

fixes #16630

This fix improves accessibility by maintaining proper ARIA relationships for tooltips.

  • Added setAriaDescribedBy to dynamically set aria-describedby attribute on the target element when the tooltip is created.
  • Added removeAriaDescribedBy to remove the aria-describedby attribute when the tooltip is removed.

… removed for tooltip

This fix improves accessibility by maintaining proper ARIA relationships for tooltips.

- Added `setAriaDescribedBy` to dynamically set `aria-describedby` attribute on the target element when the tooltip is created.
- Added `removeAriaDescribedBy` to remove the `aria-describedby` attribute when the tooltip is removed.
Copy link

vercel bot commented Nov 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2024 3:30pm

Copy link

vercel bot commented Nov 29, 2024

Someone is attempting to deploy a commit to the primetek Team on Vercel.

A member of the Team first needs to authorize it.

@mertsincan mertsincan merged commit f03542f into primefaces:master Dec 6, 2024
1 of 4 checks passed
@mertsincan
Copy link
Member

Thanks a lot for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltip: aria-describedBy not applied to target
2 participants