Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for KeyboardEvent.key in inputnumber #14776 #16863

Closed
wants to merge 1 commit into from

Conversation

askberentsen
Copy link
Contributor

@askberentsen askberentsen commented Nov 27, 2024

both UIEvent.which and KeyboardEvent.keyCode are deprecated. Testing frameworks such as 'testing-library' (https://github.com/testing-library/user-event/releases/tag/v14.0.0) for example, explicitly do not support either of these when simulating user events.

#14776

both UIEvent.which and KeyboardEvent.keyCode are deprecated. 
Testing frameworks such as 'testing-library' (https://github.com/testing-library/user-event/releases/tag/v14.0.0) for example, explicitly do not support either of these when simulating user events.
Copy link

vercel bot commented Nov 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2024 0:03am

Copy link

vercel bot commented Nov 27, 2024

@askberentsen is attempting to deploy a commit to the primetek Team on Vercel.

A member of the Team first needs to authorize it.

@askberentsen askberentsen marked this pull request as draft November 27, 2024 12:08
@askberentsen askberentsen marked this pull request as ready for review November 27, 2024 12:09
@askberentsen askberentsen changed the title added support for KeyboardEvent.key in inputnumber added support for KeyboardEvent.key in inputnumber #14776 Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant