Fix #16634 - reset accordion ActiveTab public method #16838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
@kievsash is attempting to deploy a commit to the primetek Team on Vercel. A member of the Team first needs to authorize it. |
mertsincan
added
the
Resolution: Needs Revision
|
Thanks a lot for your contribution! Could you please remove package-lock.json from PR? |
kievsash
force-pushed
the
accordion-active-tab-reset-on-tabsdata-change
branch
from
b6b4e76 to
de12174
Compare
|
Hi @mertsincan |
mertsincan
removed
the
Resolution: Needs Revision
|
Thanks a lot for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #16634
Problem: In accordion with ngFor-ed tabs when tabs array is changed active tab is still stay active.
Solution: provide public method resetActiveTab() to be able to reset it manually on data change.
Usage example:
code