Fix: PanelMenu(15403) - Submenu displays angledownicon when submenu is collapsed

[mark7p]

Resolves #15403

Problem:: The logic from ngOnChanges() forces the component to create new processedItems with expanded: undefined.

Solution: Added check to keep expanded properties.

This is a possible solution for #16781 too, but I created another PR(#16791) with the fix for the hide animation.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment

Name	Status	Preview	Updated (UTC)
primeng	⬜️ Ignored (Inspect)	Visit Preview	Nov 20, 2024 10:43am

[vercel]

@mark7p is attempting to deploy a commit to the primetek Team on Vercel.

A member of the Team first needs to authorize it.

[josefKiefer]

@mark7p, I believe this is still an issue. I upgraded my app to use 17.18.13 and it still shows the down icon when the submenu is collapsed. Please let me know if I should open a new issue and thank you for your work on this.

[mark7p]

Hi @josefKiefer , as for your issue #16781, the reason that the down icon still shows is because the submenu should retain its expanded state once its parent is opened again. If you toggled the submenu (labelled "New") open, then toggled another top level menu ("Calendar") open, instead of the submenu ("New") collapsing, its parent menu ("Users") will collapse -- considered that the property multiple is not enabled.

I have tested it with the latest v17.18.13 https://v17.primeng.org/panelmenu#controlled on Chrome and Firefox and it behaves as it should following the steps you mentioned here:

Click Users > New > Member
Click another top level menu (such as Calendar)
Click Users again and see that the New submenu is using the angledownicon instead of the anglerighticon. In addition, when >clicking on the New submenu, there is no animation to open it up.

The actual bug on #16781 is that the submenu doesn't show its children when in expanded state. The angle down icon shows its right state, but the panel refuses to expand. I believe you misunderstood the right behavior of submenu because of this. Here is the expected behavior you provided:

Expected behavior

1. The chevron should be pointed to the right, indicating the submenu item is collapsed.
2. Clicking that submenu item should expand it with an animation.
3. When all other submenu items collapse, they should have an animation just like the top-level menu items have.

The first point in your Expected Behavior should be 1. The chevron should still be pointed down - indicating the submenu item is expanded and the children are visible.

You can observe this submenu behavior throughout the PrimeTek UI Suites https://v3.primevue.org/panelmenu/ https://primereact.org/panelmenu/ although by default, they are using multiple = true.

If I'm missing something regarding your issue, let me know.