Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (v18): Modernize virtualscroller and expand test #16594

Closed

Conversation

medbenmakhlouf
Copy link

Refactor:
Updated the VirtualScroller component to leverage Angular's new signal-based inputs for enhanced reactivity and performance optimization.

Test Cases: Added comprehensive test cases to cover:
Dynamic input handling (label, icon, image)
Inline styles and CSS class binding
Size variations (normal, large, xlarge)
Shape variations (square, circle)
Error handling for image loading
Accessibility (aria-label, aria-labelledby)
Custom styling and class inputs (styleClass, style)

Fix #16546

Copy link

vercel bot commented Oct 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Oct 20, 2024 11:42pm
primeng-v18 ⬜️ Ignored (Inspect) Visit Preview Oct 20, 2024 11:42pm

@medbenmakhlouf
Copy link
Author

Looks like this component is dropped in v18. will close this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants