fix: primefaces#16557 - V18 extend card theming support #16558
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Added new card theme tokens + Adjusted docs
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
+ Fix PR-Checker NPM Version
mertsincan
added
the
Status: Discussion
|
I'm afraid we can't add new tokens right now, the tokens are shared between all Prime UI libraries and the Figma UI Kit needs to be updated when a new token is added so it has its own process and timeline. We're currently focused on stability of the theming system not adding new tokens until v18 final. New tokens cannot be added v18.1.0. For now you can extend it yourself with custom tokens, here is an example from Vue version, same applies to NG; https://www.youtube.com/watch?v=galIbID_Ywo However eventually, I think we should add the tokens you mentioned. We've bookmarked this PR when new card tokens arrive in v18.1.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #16557