Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #16225 multiselect-items-wrapper a11y issue #16226

Closed
wants to merge 1 commit into from
Closed

fixes #16225 multiselect-items-wrapper a11y issue #16226

wants to merge 1 commit into from

Conversation

TaneliTuomola
Copy link

fixes #16225 #15003

@vercel Vercel
Copy link

vercel bot commented Aug 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Aug 14, 2024 10:43am

@cetincakiroglu
Copy link
Contributor

Hi,

Thanks for the PR. This implementation breaks the current tabbing behavior of multiselect component. Could you please make it behave the same as in the dropdown? We have the same implementation in the dropdown component.

@cetincakiroglu cetincakiroglu added the Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. label Aug 15, 2024
@TaneliTuomola
Copy link
Author

TaneliTuomola commented Aug 16, 2024 •
edited
Loading

Hi,

Thanks for the PR. This implementation breaks the current tabbing behavior of multiselect component. Could you please make it behave the same as in the dropdown? We have the same implementation in the dropdown component.

I was unable to reproduce any of the keyboard usage issues. The component works the same as before the change. @cetincakiroglu

@mertsincan mertsincan added Status: Discussion Issue or pull request needs to be discussed by Core Team and removed Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. labels Nov 18, 2024
@mertsincan
Copy link
Member

Thanks a lot for your contribution! Unfortunately, this PR has conflicts, so I cannot merge it. Could you please create a new PR and open a corresponding issue for this PR? Then, I'll merge asap

@mertsincan mertsincan closed this Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Discussion Issue or pull request needs to be discussed by Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiselect: Scrollable region must have keyboard access
3 participants
@TaneliTuomola @cetincakiroglu @mertsincan