fix(toast): Add focus and hideOnEscape to enhace accessibility #16078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
Can you verify this PR #16078 against reproducer : https://stackblitz.com/edit/uqdfhq See Issue #16026 for more details about the reproducer |
rosenthalj
approved these changes
Jul 24, 2024
|
After talk with @cetincakiroglu I will close my PR but if someone need the same solution, you can use this workaround without any modification in the source code of PrimeNG and doing the same functionality manually: Solution provided by @cetincakiroglu: https://stackblitz.com/edit/fjbene-zqmp1q?file=src%2Fapp%2Ftoast-basic-demo.html,src%2Fapp%2Ftoast-basic-demo.ts Thanks @rosenthalj too! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #16026
DEMO in Toast
DEMO in Headless Toast