Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #16052 MultiSelect and Listbox filterby is not working #16053

Closed
wants to merge 2 commits into from

Conversation

ymg2006
Copy link
Contributor

@ymg2006 ymg2006 commented Jul 18, 2024

#16052 MultiSelect and Listbox filterby is not working
This commit synchronizes the get searchFields(). Seems it is update in other places except these two components.

MultiSelect and Listbox filterby is not working
Copy link

vercel bot commented Jul 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Jul 18, 2024 0:37am

Copy link
Contributor

@rosenthalj rosenthalj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that this PR #16052 may break the following modification to the PrimeNG "basic" demo example (replacing all City interface references to string) :

<div class="card flex justify-content-center">
    <p-multiSelect 
        [options]="cities" 
        [(ngModel)]="selectedCities" 
        placeholder="Select Cities" />
</div>
export class MultiSelectBasicDemo implements OnInit {

    cities!: string[];

    selectedCities!: string[];

    ngOnInit() {
        this.cities = [
            'New York',
            'Rome',
            'London',
            'Istanbul',
            'Paris'
        ];
    }
}

Note: Testing your changes against all the the PrimeNG multiselect demos would not have been"complete" since all the demos define optionLabel.

src/app/components/multiselect/multiselect.ts Show resolved Hide resolved
src/app/components/listbox/listbox.ts Show resolved Hide resolved
@cetincakiroglu cetincakiroglu added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Jul 18, 2024
@mertsincan mertsincan added Resolution: Needs More Information More information about the issue is needed to find a correct solution and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Nov 18, 2024
@mertsincan
Copy link
Member

For now, closed! If a new update comes from your side, please reopen this PR. Thanks a lot for your understanding!

@mertsincan mertsincan closed this Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Needs More Information More information about the issue is needed to find a correct solution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants