Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(splitbutton): 15706 add ability to have rotation of chevron icon #15709

Closed
wants to merge 4 commits into from

Conversation

tri-harmoney
Copy link
Contributor

@tri-harmoney tri-harmoney commented May 27, 2024

Resolves #15706

Copy link

vercel bot commented May 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview May 29, 2024 8:32am

Copy link
Contributor

@SoyDiego SoyDiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont understand why is necessary the functionality rotate in the splitbutton 😕

@tri-harmoney
Copy link
Contributor Author

@SoyDiego I changed the proposal. We want to be able to rotate the chevron based on if the split button is expanded or not.
While not doing too much I added a css class is-expanded. This is a general solution and we can now rotate the chevron in our css based on that class. Do you agree more with this solution?

@cetincakiroglu
Copy link
Contributor

Hi,

Rotating the chevron is not in our design system. You can use dropdownicon template to customize the icon. Thanks a lot for the effort, closing the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SplitButton: rotate chevron while TieredMenu is open
3 participants