Improve calendar keyboard accessibility #15451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
PronDmytro
changed the title
| @@ -243,6 +243,7 @@ export const CALENDAR_VALUE_ACCESSOR: any = { | |||
| [ngClass]="{ 'p-highlight': isSelected(date) && date.selectable, 'p-disabled': !date.selectable }" | |||
| (click)="onDateSelect($event, date)" | |||
| draggable="false" | |||
| [attr.data-date]="formatDateKey(formatDateMetaToDate(date))" | |||
There was a problem hiding this comment.
why to add attr.data-date ?
There was a problem hiding this comment.
To find the necessary cell for focus, you can refer to an example of its usage in row 2218. Another solution to this problem, albeit not ideal, is to use an ID. However, this approach may not be as effective.
There was a problem hiding this comment.
Thanks a lot we'll discuss whether to add new attribute or not and review the PR again upcoming week's release.
cetincakiroglu
added
Resolution: Needs More Information
cetincakiroglu
removed
Status: Pending Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14995
Updated the calendar component to include keyboard navigation. Users can now utilize keys such as Page Up, Page Down, Home, and End to navigate through the calendar as mentioned in the issue description. The update also involves refactoring date formatting into dedicated functions to improve code readability and maintainability.