Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #14954 Dropdown head is empty when no selected option provided #15383

Merged
merged 4 commits into from
May 9, 2024
Merged

Fix #14954 Dropdown head is empty when no selected option provided #15383

merged 4 commits into from
May 9, 2024

Conversation

tal-ladi
Copy link
Contributor

@tal-ladi tal-ladi commented Apr 27, 2024 •
edited
Loading

fixes #14954

  1. Generate the :nbsp; when a no value is provided as done in the none templated version.
  2. Set the placeholder to have the floating-label value when a floating label is provided to adjust the dropdown width to fit the floating label value

@vercel Vercel
Copy link

vercel bot commented Apr 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview May 9, 2024 8:27am

@cetincakiroglu cetincakiroglu added the Status: Pending Review Issue or pull request is being reviewed by Core Team label May 3, 2024
@cetincakiroglu cetincakiroglu removed the Status: Pending Review Issue or pull request is being reviewed by Core Team label May 9, 2024
@cetincakiroglu
Copy link
Contributor

Hi,

Thanks a lot for the effort and support!

@cetincakiroglu cetincakiroglu merged commit 2cd0548 into primefaces:master May 9, 2024
2 of 3 checks passed
@Delagen
Copy link
Contributor

Delagen commented May 13, 2024 •
edited
Loading

@tal-ladi What can i do if I don't want nbsp and floating label? I want simple empty control

@Rodolphe33 Rodolphe33 mentioned this pull request Jun 11, 2024
Open
@diaz-rigo diaz-rigo mentioned this pull request Jun 20, 2024
Open
@LoaderB0T LoaderB0T mentioned this pull request Jul 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dropdown head is empty if no value is provided
3 participants
@tal-ladi @cetincakiroglu @Delagen