Fixes #15367 - SpeedDial non-linear menu items are misaligned #15368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Dive576
changed the title
Dive576
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15367
Background
In a previous PR (#13726), a change was made so that menu item actions would not be added to the DOM unless the speed dial menu was visible. This was done to prevent those menu items from interfering with clicks on elements below the items while the menu was closed.
However, the size of the menu item actions is used to position the items and the calculation is performed while the actions aren't in the DOM resulting in the items being misaligned. Additionally, the removal of the menu item actions causes the closing animation of the Speed Dial to not be displayed.
Changes
focusedOptionIndexsignal which was causing an exception when pressing the enter key on a focused menu item.