Menubar: Enter key moves focus at first menuitem #15359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
SoyDiego
reviewed
Apr 25, 2024
| @@ -1050,10 +1050,6 @@ export class Menubar implements AfterContentInit, OnDestroy, OnInit { | |||
|
|
|||
| anchorElement ? anchorElement.click() : element && element.click(); | |||
|
|
|||
| const processedItem = this.visibleItems[this.focusedItemInfo().index]; | |||
There was a problem hiding this comment.
mmm I'm not sure if this is ok for accessibility.
@TaneliTuomola could you check it, please? :)
There was a problem hiding this comment.
I am aware there is a known issue(#15048) for accessibility for keyboard navigation whilst using Microsoft narrator. That issue I believe still needs to be resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issue #15040
Fixed #15040
menu items now keeps the focus the clicked/Enterkey one and no longer focuses back to first menuitem