Fix Issue with frozen columns #12408 #15302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
Hello Prime team, |
Lolibai
changed the title
Lolibai
changed the title
cetincakiroglu
added
the
Status: Pending Review
| recalculateColumns() { | ||
| const siblings = DomHandler.siblings(this.el.nativeElement); | ||
| const index = DomHandler.index(this.el.nativeElement); | ||
| const time = (siblings.length - index + 1) * 50; |
There was a problem hiding this comment.
Why multiply by 50?
cetincakiroglu
removed
the
Status: Pending Review
| recalculateColumns() { | ||
| const siblings = DomHandler.siblings(this.el.nativeElement); | ||
| const index = DomHandler.index(this.el.nativeElement); | ||
| const time = (siblings.length - index + 1) * 50; |
There was a problem hiding this comment.
This line only work for alignFrozen='right'. And this created new issue #15852.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defect Fixes
Fixes #15303
Describe the bug
Video with the actual issue attached
Screen.Recording.2022-12-20.at.14.07.52.mov
Environment
Frozen Columns
Reproducer
Lolibai
Angular version
17.3.1
PrimeNG version
17.13.0
Build / Runtime
Angular CLI App
Language
TypeScript
Node version (for AoT issues node --version)
20.12.2
Browser(s)
Chrome 123.0.6312.123
Steps to reproduce the behavior
Screen.Recording.2022-12-20.at.14.07.52.mov
Expected behavior
All columns should be freezed as per attribute and directive assignment.
Stackblitz
Reproduction