#15260: Messages component uses closable and id from Message
#15261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conditional close and docs update
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
rosenthalj
reviewed
Apr 12, 2024
rosenthalj
reviewed
Apr 12, 2024
rosenthalj
reviewed
Apr 12, 2024
rosenthalj
reviewed
Apr 12, 2024
rosenthalj
reviewed
Apr 12, 2024
rosenthalj
reviewed
Apr 12, 2024
jacver
changed the title
closableclosable and id from Message
rosenthalj
approved these changes
Apr 12, 2024
| @@ -42,7 +42,7 @@ import { Subscription, timer } from 'rxjs'; | |||
| role="alert" | |||
| [@messageAnimation]="{ value: 'visible', params: { showTransitionParams: showTransitionOptions, hideTransitionParams: hideTransitionOptions } }" | |||
| > | |||
| <div class="p-message-wrapper" [attr.data-pc-section]="'wrapper'"> | |||
| <div class="p-message-wrapper" [attr.data-pc-section]="'wrapper'" [attr.id]="msg.id || null"> | |||
There was a problem hiding this comment.
ok, but this addresses a different issue
| @@ -60,7 +60,7 @@ import { Subscription, timer } from 'rxjs'; | |||
| <span *ngIf="msg.summary" class="p-message-summary" [attr.data-pc-section]="'summary'">{{ msg.summary }}</span> | |||
| <span *ngIf="msg.detail" class="p-message-detail" [attr.data-pc-section]="'detail'">{{ msg.detail }}</span> | |||
| </ng-template> | |||
| <button class="p-message-close p-link" (click)="removeMessage(i)" *ngIf="closable" type="button" pRipple [attr.aria-label]="closeAriaLabel" [attr.data-pc-section]="'closebutton'"> | |||
| <button class="p-message-close p-link" (click)="removeMessage(i)" *ngIf="closable && (msg.closable ?? true)" type="button" pRipple [attr.aria-label]="closeAriaLabel" [attr.data-pc-section]="'closebutton'"> | |||
| @@ -1313,7 +1313,7 @@ | |||
| "values": [ | |||
| { | |||
| "name": "Message", | |||
| "description": "Deines valid options for the message.", | |||
| "description": "Defines valid options for the message.", | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defect Fixes
#15260
<p-messages>element does not usemsg.closablein the*ngIf. This means that when adding multiple messages to the service, you cannot have some closable and others not closable.This PR adds the logic and updates the documentation to fix this and allow the ID attribute to be set from the
Messageobject.