fix #15144 DynamicDialog get closeAriaLabel

[TaneliTuomola]

fixes #15144

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
primeng	⬜️ Ignored (Inspect)	Visit Preview		Apr 2, 2024 8:35am

[cetincakiroglu]

Hi @TaneliTuomola,

For aria labels, you should place it inside the aria object in translation object in primengconfig.ts (don't forget to update interfaces). Also, you should access it inside the component below to make it translatable. And one more thing, close exists in aria object inside the translation in primengconfig.ts. Could you please useclose instead of creating a new property for the same thing?

Correct usage:

    get closeAriaLabel(): string {
        return this.config.getTranslation(TranslationKeys.ARIA)['close'];
    }

You can find examples of this usage in various places inside the library.
I'll accept your PR after these changes are done. Please tag me after the changes.

Thanks in advance.

[SoyDiego]

Hi @TaneliTuomola,

For aria labels, you should place it inside the aria object in translation object in primengconfig.ts (don't forget to update interfaces). Also, you should access it inside the component below to make it translatable. And one more thing, close exists in aria object inside the translation in primengconfig.ts. Could you please useclose instead of creating a new property for the same thing?

Correct usage:

    get closeAriaLabel(): string {
        return this.config.getTranslation(TranslationKeys.ARIA)['close'];
    }

You can find examples of this usage in various places inside the library. I'll accept your PR after these changes are done. Please tag me after the changes.

Thanks in advance.

good catch!

[TaneliTuomola]

Hi @TaneliTuomola,

For aria labels, you should place it inside the aria object in translation object in primengconfig.ts (don't forget to update interfaces). Also, you should access it inside the component below to make it translatable. And one more thing, close exists in aria object inside the translation in primengconfig.ts. Could you please useclose instead of creating a new property for the same thing?

Correct usage:

    get closeAriaLabel(): string {
        return this.config.getTranslation(TranslationKeys.ARIA)['close'];
    }

You can find examples of this usage in various places inside the library. I'll accept your PR after these changes are done. Please tag me after the changes.

Thanks in advance.

Thanks for the advice @cetincakiroglu. Global text is better for setting the text of the Close button than a separate property.

Would it be worth refactoring the icon button texts of the Dialog and ConfirmDialog components in the same way? Now they use a separate Input property: @Input() closeAriaLabel: string | undefined;

[cetincakiroglu]

Hi @TaneliTuomola,

Thanks a lot for the effort and support!