Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #15024 table filter row aria-labels #15025

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

TaneliTuomola
Copy link

fixes #15024
Added aria-label support.

Copy link

vercel bot commented Mar 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Mar 13, 2024 7:44am

@cetincakiroglu
Copy link
Contributor

cetincakiroglu commented Mar 14, 2024

Hi,

Thanks for the effort and support, your fix is correct but we need to get ariaLabel from the translateService to make it compatible with i18n. Could you please update the PR?

It should look like this:

// taken from the table.ts line 5283
    get showMenuButtonLabel() {
        return this.config.getTranslation(TranslationKeys.SHOW_FILTER_MENU);
    }

Please tag me after updating the PR.

@cetincakiroglu cetincakiroglu added the Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. label Mar 14, 2024
@TaneliTuomola
Copy link
Author

I thought that it would be better to be able to set aria-label to each p-columnFilter element separately (via input) and let the client application handle translations if needed. In your suggestion there will be only one generic aria-label in every p-columnFilter element in every table? @cetincakiroglu

@cetincakiroglu cetincakiroglu merged commit 1d69273 into primefaces:master Mar 19, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table / Filter Row: Form elements missing aria-label
2 participants