fixes #15014: fixed issue with input number loosing focus #15015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
This was referenced Mar 12, 2024
|
Hi @rosenthalj, Thanks a lot for the effort and support! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #15014
I created a new unit test (should model value) in inputnumber.spec.ts.
The following screenshot is the unit test results for inputnumber.spec before the fix, the new unit test fails.
The following screenshot is the unit test results for inputnumber.spec after the fix, the new unit test passes.
The following video is running the inputNumber demo with the PR changes and shows that issue 1) has been fixed.
inputNumberFixNoNullPointerException.mov
The following video is running the reproducer with the PR changes and shows that issue 2) has been fixed.
inputNumberFixFocusChangesModelFromNumberToString.mov