fixes #14962 - ContextMenu | onHide, onShow event is not being triggered when you right click twice continuously

[ymg2006]

context menu onshow event should not be inside onOverlayAnimationStart since it is not being fired when context menu is clicked twice simultaneousl

Defect Fixes

When submitting a PR, please also create an issue documenting the error and manually link to an issue or mention it in the description using #<issue_id>.

Feature Requests

Due to company policy, we are unable to accept feature request PRs with significant changes as such cases has to be implemented by our team following our own processes.
Smaller scaled feature implementations such as adding a property to a component will be considered for merging.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
primeng	⬜️ Ignored (Inspect)	Visit Preview		Mar 11, 2024 10:39am

[cetincakiroglu]

Hi @ymg2006,

Thanks for the effort and support!

Could you please link the related issue with the PR and tag me afterward so I can include it in the milestone and merge your PR? Also could you please put onHide and onShow emitters after the visible signal value changed at the bottom of both methods?

[ymg2006]

@cetincakiroglu the issue link is: #14964.
The onHide event call is moved after this.visible.set(false) method as per request, but the onShow is not moved because when we dynamically want to change context menu items, it gets incorrect position, this.position() is not being called so I put it before this.position() and this.visible.set(true) methods.

[cetincakiroglu]

@ymg2006

The issue link is not correct it's your PR link. Please link the PR with an active issue if it exists or open a new issue describing the malfunction and link the PR.

[ymg2006]

@cetincakiroglu
new issue created, this commit closes issues: #15032, #14962

[cetincakiroglu]

Hi,

Thanks for the effort and support!