feat: Dynamic dialog. Child component reference to be able to #14957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ld component subject to DialogRef
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
cetincakiroglu
added
the
Status: Pending Review
|
Hi, Could you please remove other changes package, inputnumber etc. and resolve the conflicts. |
cetincakiroglu
added
Resolution: Needs Revision
vigalo
force-pushed
the
dynamicdialog-childcomponentref
branch
from
9edb20f to
67e1c46
Compare
Done, thanks |
|
Thumbs up I would like to see this implemented as well, thanks. |
|
Hi, Thanks a lot for the effort and support! Could you please link the related issue with the PR if it exists or create an issue and link with the PR so it can be closed after the PR merged. I've added it to this one. |
cetincakiroglu
removed
the
Resolution: Needs Revision
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
With the current implementation is hard to do things like use the child component public API (i.e. to populate inputs) because the component is created asynchronously and trying to pass data using the angular lifecycle hooks to access the child component throws errors because often is undefined. Pass the data through the DynamicDialogConfig is a bit tricky.
So I made generic the open method of the DialogService and DynamicDialogRef. The open method of the DialogService now returns a typed DynamicDialogRef that has a new subject (onChildComponentLoaded) where the typed component instance is emitted when loaded.