Fixes Content-security-Policies bug #14846 #14854
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed innerHTML injection to textContent. innerHTML is not parsed as HTML, so it does not violate the CSP. Suggested fix from: #12855
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
SoyDiego
approved these changes
Feb 21, 2024
|
This issue is more complex and requires more changes. The problem is that a style element is created and appended to the head of the document without a nonce. More components suffer from this issue. PrimeNG should be able to apply the nonce to all its components' dynamic style elements via a service of some sort. It should be made compatible with Angular 16's ngCspNonce. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed innerHTML injection to textContent. innerHTML is not parsed as HTML, so it does not violate the CSP.
Fixes bug for issue: #14846
Suggested fix from: #12855