Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #14815 - Dropdown | Selected option not shown while typing in f… #14820

Closed
wants to merge 1 commit into from

Conversation

mehmetcetin01140
Copy link
Contributor

Fixes #14815

…ilter if it has value null, while having selectedItem template
Copy link

vercel bot commented Feb 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
primeng ⬜️ Ignored (Inspect) Feb 15, 2024 2:18pm

@rosenthalj
Copy link
Contributor

I believe this PR will partially fix the issue.

If the user types in letters that never match an option value then the change works. If the user types in letters that match a different option then the issue still occurs.

The video listed below shows the current PR partially working.

pratialFix.mov

Updating this PR with the following additional change will fix fully the issue:

GitHub_Desktop

The video listed below shows the PR with my proposed change fully working.

fullFix.mov

@cetincakiroglu cetincakiroglu deleted the issue-14815 branch February 23, 2024 13:08
@rosenthalj
Copy link
Contributor

@cetincakiroglu,

I just received an email that you closed issue #14815. I immediately downloaded the current master branch and it appears that this issue has not been fixed. I compared the changes to dropdown.ts to this PR #14820 (including my proposed additional changes that I provided as a comment) and it appears that all the PR changes were superseded by a different approach. Unfortunately the changes to dropdown.ts doesn't fix issue #14815.

The video listed below is using the Issue #14815 reproducer with most recent master changes and shows that issue #14815 is back to its v17.7.0 broken state.

DropdownNotWorking.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants