Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #14724, Password: Hand/Pointer icon not displayed while hovering over the eye icon in password ToggleMask mode #14725

Closed
wants to merge 1 commit into from

Conversation

akshayaqburst
Copy link
Contributor

Defect Fixes

fix: #14724, Password: Hand/Pointer icon not displayed while hovering over the eye icon in password ToggleMask mode

…e hovering over the eye icon in password ToggleMask mode
Copy link

vercel bot commented Feb 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Feb 6, 2024 8:57am

@cetincakiroglu
Copy link
Contributor

Hi,

According to your update, every element with p-icon class will receive cursor: pointer style and some icon elements shouldn't take cursor: pointer;. Because of that I'm closing the PR, issue is fixed in here: f7cdbf1

@akshayaqburst
Copy link
Contributor Author

akshayaqburst commented Feb 21, 2024

Hi,

According to your update, every element with p-icon class will receive cursor: pointer style and some icon elements shouldn't take cursor: pointer;. Because of that I'm closing the PR, issue is fixed in here: f7cdbf1

I don't feel its a good way of reviewing a PR in the Open Source community. When we spend our time to raise bugs and create PR fix, you could have suggested a code change as a result of the PR review, which I would have done within a few hours time, or responded to, if I'm not planning to. Instead you raised a new PR which I don't feel is appropriate.
Thanks,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Password: Hand/Pointer icon not displayed while hovering over the eye icon in password ToggleMask mode
3 participants