fix(14715): selecting a falsy value (such as '0' or 0) should not show placeholder #14719
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
…w placeholder (especially when such option has a label)
Cr3aHal0
force-pushed
the
feature/14715-option-falsy-value-showing-placeholder-rather-than-option-label
branch
from
a0ada3d to
caeae32
Compare
|
I believe this pull request is not complete. This pull request is an attempt to fix a condition that I did not consider when the code was changed for pull request #14665. Was this pull requested fully tested with a value of 0 and using the dropdown's filtering? Please see the annotated screenshot of pull request #14665 listed below
|
…lue to have its label displayed + strict type check
|
You may find in latest commit some more changes (including the one you mentioned) about strict type check of modelValue(). I did test it against the filterable dropdown use case and it works well, both from filter and from ngModel initialization. I tweaked a bit the template of the filter example to get rid of the unnecessary selectionCountry check since the template is bound only if the dropdown as a valid value. Let me know if this sounds good to you |
Fixes #14715
Not sure if this is by design or if a larger set of value should or should not be accepted (such as true/false), feel free to reject this PR. I did hesitate to use ObjectUtils.isNotEmpty but since it excludes an empty string as being an authorized option, I thought it may be too much.