Fixed #14682 - Dropdown | TypeError: option.toLowerCase is not a func…

[mehmetcetin01140]

Fixes #14682

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
primeng	⬜️ Ignored (Inspect)	Visit Preview		Feb 5, 2024 11:06am

[github-actions]

Thanks a lot for your contribution! But, PR does not seem to fit our code format standards. Please run the 'npm run format' command and commit the changes.

[github-actions]

Thanks a lot for your contribution! But, PR does not seem to fit our code format standards. Please run the 'npm run format' command and commit the changes.

[basvandenberg]

@mehmetcetin01140, @cetincakiroglu I noticed that the code still contains a option.toLowerCase(), even though option has type any, and I would expect most users to provide objects as options, not strings. This PR might prevent the error for one use case, but I would expect it to still occur in other cases. I have seen multiple issues that mention this same error.

I am trying to understand the logic, to see how this can be fixed, but to me it is not clear why there are two filters. Why not always use the filterService.filter? Could you please explain why the more basic filter is used if:

!(this.filterBy || this.optionLabel) && !this.filterFields && !this.optionValue

I have a hard time trying to understand this logic, it would be great if you could provide some insight.