fix #14603 - added call to onChange.emit to multiselect's toggleAll method #14604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
SoyDiego
approved these changes
Jan 25, 2024
|
do we have any indication when the target release for this is ? |
|
@cetincakiroglu After updating to 17.7.0, I have verified that this Pull Request still fixes issue #14603 |
|
To help quickly identify the cause issue #14603 and to save PrimeNG developers time searching/comparing code:
This PR is a simple fix that adds the missing call to onChange to multiselect's toggleAll method |
This was referenced Feb 16, 2024
|
Any idea, when it will be merged? A lot of multi-select were used in my project :( |
|
This PR is superseded by PR #14826 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #14603
I added a call to onChange.emit to the toggleAll method. This functionality worked in v15.x and was broken sometime in v16.x. After analyzing the differences, it appears that a call to onChange.emit was missing in v17.x
The first video shows that the reproducer is fixed with this pull request
multiselectVideoFix1.mov
The second video shows that the PimeNG table filter row demo is fixed with this pull request
multiselectVideoFix2.mov